Skip to content

Tell regexp-util to generate regex compatible with u flag#16816

Merged
fisker merged 3 commits intoprettier:mainfrom
tats-u:u-flag
Nov 4, 2024
Merged

Tell regexp-util to generate regex compatible with u flag#16816
fisker merged 3 commits intoprettier:mainfrom
tats-u:u-flag

Conversation

@tats-u
Copy link
Copy Markdown
Contributor

@tats-u tats-u commented Nov 4, 2024

Description

non-BMP CJK characters and IVS are not recognized to CJK now.
.toString and .toRegExp in regexp-util.CharSet generate regexps incompatible with the u flag by default.
We have to pass the "u" argument to make them compatible with u.

https://prettier.io/playground/#N4Igxg9gdgLgprEAuEBDABIdW10e79AOlIOYbgvHtGBa2UWZSADQgQAOMAltAM7KioBOvEAO4AFPgi4pUAG0GoAnlwYAjXqjABrODADKqALZwAMqyhxkAM2kc4y1Rq3amakwHNkMXgFcbIa3tbuXj5wAB5McLysBrDSACoRUHyscBKWUtYMHK5ScACKnhDwFlY+AFYcIdrZeQVFSGkZIACOtXDCAkwSaBwAtKZwACaD9CAeqKxSrgDCEHp6qMhoUlIjWVAuOQCCMB6sSp7wwhHGpsXpPgAWMHpSAOoXrPAcTmBw2uKPrABuj3KLYBxFCAvt4AJJQIawbRgSIsTYQ7QwOQ5M6NJgCay3VRMRamL4REYmay8GDtVAueaonxOXjExbzXjqAZCKAjdEmGC3VgDGAXZAADgADAxeHAWqxRWSKQt6iUGDBUEouTy+UgAEwMTzWWKK1JykBwPRKQZDAaGVDrTzkuAAMQgvHmO1ci1QBwgIAAvh6gA

https://prettier.io/playground/#N4Igxg9gdgLgprEAuEBDABIdW10e79AOlINohgAtuAAu0cVRVUSADQgQAOMAltAM7KioBO-CAHcACgIQ8UqADbDUATx5MARv1RgA1nBgBlVAFs4AGXZQ4yAGayucVeq07dLDWYDmyGPwCudkLYN2Tx8-OAAPFjh+diNYWQAVKKgBdjgpaxlbJi53GTgARW8IeCsbPwArLjDdXIKikqQMrJAAR3q4USEWKTQuAFpzOAATYcYQL1R2GXcAYQgDA1RkNBkZMZyoNzyAQRgvdhVveFEo03NSzL8ACxgDGQB1K-Z4LhcwOF1JZ-YAN2eFZZgLjKEA-XwASSgI1gujA0TY2yhuhgCjyF2aLCEtnu6hYy3MPyiYzMtn4ME6qDci3Rfhc-FJy0W-E0QxEUDGmLMMHu7CGMCuyAAHAAGJj8OBtdjiilUpaNMpMGCoFQ8vkCpAAJiY3ls8WV6QVIDgBhUwxGQ2MqE23kpcAAYhB+Is9u5lqgjhAQABfL1AA

https://prettier.io/playground/#N4Igxg9gdgLgprEAuEBDABIdW10e7gOlIEIbg7fuGmGDaIYALbgALtV2GBCviADQgQAOMAltAM7JQqAE4iIAdwAKohIJSoANhNQBPQewBGI1GADWcGAGVUAWzgAZHlDjIAZkv5wtO-YaOdd1gObIYIgFdnECdTHj9A4LgAD044ER5zWCUAFXioUR44eQdFJ3Z+H0U4AEUAiHh7R2CAK35ooyLS8sqkXPyQAEcWuClxTnk0fgBaGzgAEwm2EH9UHkUfAGEIU1NUZDRFRWnCqG9igEEYfx5NAPgpeKsbKrzggAsYU0UAdXueeH5PMDgjOQ+eAA3D6qDZgfgaECAoIASSgk1gRjACW4B3hRhgqmKtw6nHETheOk4GxsgPi02sThEMD6qG8axxwU8IipGzWIj040kUGmeOsMBePHGMHuyAAHAAGdgiODdHgy2n09ZtarsGCoTSC4WipAAJnYAScKQ1OVVIDgpk0E0m4wsqD2ATpcAAYhARGtjj4NqhzhAQABff1AA

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

Comment thread changelog_unreleased/markdown/16816.md Outdated
Co-authored-by: fisker Cheung <[email protected]>
@tats-u tats-u marked this pull request as ready for review November 4, 2024 08:34
@fisker fisker merged commit dc8df0a into prettier:main Nov 4, 2024
@tats-u tats-u deleted the u-flag branch November 4, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants