Skip to content

Keep non-html doctype unchanged #16765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sosukesuzuki merged 4 commits into from
Nov 24, 2024
Merged

Keep non-html doctype unchanged #16765

sosukesuzuki merged 4 commits into from
Nov 24, 2024

Conversation

@fisker
Copy link
Member

@fisker fisker commented Oct 18, 2024 •
edited
Loading

Description

Fixes #15476
Closes #16588

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as ready for review October 18, 2024 15:04
@fisker fisker mentioned this pull request Nov 24, 2024
Closed
11 tasks
@sosukesuzuki sosukesuzuki merged commit c706678 into prettier:main Nov 24, 2024
27 checks passed
@fisker fisker deleted the html-doctype branch November 24, 2024 14:27
@fisker fisker mentioned this pull request Apr 23, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proposal: Add --doctype-case option for customizable DOCTYPE casing Prettier breaks XHTML documents by incorrectly lowercasing DOCTYPE

2 participants

@fisker @sosukesuzuki