Print AtHead node from glimmer via print()
#16346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
reviewed
Jun 4, 2024
| return "null"; | ||
|
|
||
| case "VarHead": // Handled in `printPathExpression` | ||
| case "ThisHead": // Handled in `printPathExpression` |
Member
There was a problem hiding this comment.
I'm not familiar with these syntaxes, but it looks like the handling of the ThisHead node isn't included in the printPathExpression diff. What's going on?
Member
Author
There was a problem hiding this comment.
VarHead or ThisHead are head of PathExpression, they can't go through print, because we need the original text to check isPathExpressionPartNeedBrackets
Member
|
Could you rename this PR title to more understandable? |
sosukesuzuki
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨