Skip to content

WIP: Update to [email protected]#16134

Closed
seiyab wants to merge 19 commits intoprettier:mainfrom
seiyab:11828-update-remark-parse
Closed

WIP: Update to [email protected]#16134
seiyab wants to merge 19 commits intoprettier:mainfrom
seiyab:11828-update-remark-parse

Conversation

@seiyab
Copy link
Copy Markdown
Collaborator

@seiyab seiyab commented Mar 1, 2024

Description

Issue: #11828
Related: #11867

I tried to update remark-parse. It is very hard so I stopped it. Submitting PR because it might help someone who will try it.
Currently,

  • Many snapshots fail. Most of them look to relate to character escaping.
  • Probably some snapshots get better.
  • Have not worked on MDX yet.
  • Build fails with error ERROR: [plugin: throw-warnings] Unicode property escapes in regular expressions are not available in the configured target environment ("chrome109", "edge119", "firefox120", "ios15.6", "node14", "opera104", "safari16.6")

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

seiyab added 19 commits February 3, 2024 16:41
yarn test ./tests/format/markdown

Test Suites: 21 failed, 22 passed, 43 total
Tests:       305 failed, 941 passed, 1246 total
Snapshots:   303 failed, 1 obsolete, 940 passed, 1243 total
TBW: mismatch open-close ( {{ ... %} )
yarn test ./tests/format/markdown

Test Suites: 20 failed, 23 passed, 43 total
Tests:       303 failed, 943 passed, 1246 total
Snapshots:   301 failed, 1 obsolete, 942 passed, 1243 total
yarn test ./tests/format/markdown

Test Suites: 18 failed, 25 passed, 43 total
Tests:       291 failed, 955 passed, 1246 total
Snapshots:   289 failed, 1 obsolete, 954 passed, 1243 total
yarn test ./tests/format/markdown

Test Suites: 18 failed, 25 passed, 43 total
Tests:       278 failed, 967 passed, 1245 total
Snapshots:   278 failed, 966 passed, 1244 total
yarn test ./tests/format/markdown

Test Suites: 18 failed, 25 passed, 43 total
Tests:       266 failed, 979 passed, 1245 total
Snapshots:   266 failed, 978 passed, 1244 total
yarn test ./tests/format/markdown

Test Suites: 16 failed, 27 passed, 43 total
Tests:       261 failed, 984 passed, 1245 total
Snapshots:   261 failed, 983 passed, 1244 total
yarn test ./tests/format/markdown

Test Suites: 16 failed, 27 passed, 43 total
Tests:       257 failed, 988 passed, 1245 total
Snapshots:   257 failed, 987 passed, 1244 total
@seiyab
Copy link
Copy Markdown
Collaborator Author

seiyab commented Mar 1, 2024

OMG I missed #13676 😭

@seiyab seiyab closed this Mar 1, 2024
fisker added a commit to j-f1/forked-prettier that referenced this pull request Jun 22, 2024
@fisker fisker mentioned this pull request Jun 22, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant