Skip to content

Add newline between markdown footnote definitions#16063

Merged
fisker merged 3 commits intoprettier:mainfrom
Atema:main
May 25, 2024
Merged

Add newline between markdown footnote definitions#16063
fisker merged 3 commits intoprettier:mainfrom
Atema:main

Conversation

@Atema
Copy link
Copy Markdown
Contributor

@Atema Atema commented Feb 8, 2024 •
edited
Loading

Description

Ensures there are newlines between markdown footnote definitions, to comply with the standard set by Pandoc (https://pandoc.org/MANUAL.html#footnotes):

Each footnote should be separated from surrounding content (including other footnotes) by blank lines.

Resolves #8301

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker
Copy link
Copy Markdown
Member

fisker commented May 10, 2024

Can you fix coflicts?

@kachkaev
Copy link
Copy Markdown
Member

kachkaev commented May 24, 2024

@Atema can you please run Prettier for src/language-markdown/printer-markdown.js? CI is failing.

kachkaev
kachkaev approved these changes May 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kachkaev kachkaev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Atema! 🙌
@fisker WDYT?

@fisker
Copy link
Copy Markdown
Member

fisker commented May 25, 2024

I've approved two weeks ago, 😄

@fisker fisker merged commit 41f1dff into prettier:main May 25, 2024
@kachkaev kachkaev added this to the 3.3 milestone May 31, 2024
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
kurtinatlanta pushed a commit to kurtinatlanta/prettier that referenced this pull request Dec 27, 2025
@Atema @kurtinatlanta
Add newline between markdown footnote definitions (prettier#16063)
e79d8f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisker fisker fisker approved these changes

@kachkaev kachkaev kachkaev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

Whitespace is removed from between footnotes

3 participants

@Atema @fisker @kachkaev