Add jsonc parser#15831
Merged
fisker merged 19 commits intoprettier:mainfrom Jan 2, 2024
Merged
Conversation
fisker
commented
Dec 19, 2023
Comment on lines
118
to
119
| <!-- TODO[@fisker]: Check this --> | ||
| If this option is set to `preserve`, `singleQuote` to `false` (default value), and `parser` to `json5`, double quotes are always used for strings. This effectively allows using the `json5` parser for “JSON with comments and trailing commas”. |
Member
Author
Member
There was a problem hiding this comment.
It'd be a breaking change with little gain. Maybe better to keep the logic and just remove this part from the docs.
fisker
commented
Dec 19, 2023
| createLanguage(linguistLanguages["JSON with Comments"], () => ({ | ||
| parsers: ["jsonc"], | ||
| vscodeLanguageIds: ["jsonc"], | ||
| filenames: [...data.filenames, ".eslintrc"], |
Member
Author
There was a problem hiding this comment.
.eslintrc is not listed in https://eslint.org/docs/latest/use/configure/configuration-files#configuration-file-formats, and .eslintrc.json already in linguistLanguages.
sosukesuzuki
approved these changes
Dec 28, 2023
3 tasks
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Feb 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15553
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨