group not needed if we know there's a hardline or a breakParent inside#15795
Merged
fisker merged 2 commits intoprettier:mainfrom Dec 17, 2023
Merged
group not needed if we know there's a hardline or a breakParent inside#15795fisker merged 2 commits intoprettier:mainfrom
fisker merged 2 commits intoprettier:mainfrom
Conversation
thorn0
approved these changes
Dec 15, 2023
fisker
approved these changes
Dec 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
group containing
hardlineorbreakParentonly make sense if the rest of the code relies on theGrouptype to make a different decision.This one doesn't affect any test.
I also found one here:
prettier/src/language-js/embed/html.js
Lines 76 to 85 in 153ffd5
which could be replaced by
and another here:
prettier/src/language-js/print/decorators.js
Lines 16 to 19 in 153ffd5
But the benefit is so small that you can make that decision.
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨