Skip to content

Fix expect call in dts test #15766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thorn0 merged 1 commit into from
Dec 5, 2023
Merged

Fix expect call in dts test #15766

thorn0 merged 1 commit into from
Dec 5, 2023

Conversation

@thorn0
Copy link
Member

@thorn0 thorn0 commented Dec 5, 2023

Description

Jest's expect iterates all the properties of diagnostic objects triggering a deprecation error in a getter. That's why now it gets an array of formatted messages instead. Also formatted messages are easier to understand when the test fails.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@thorn0 thorn0 mentioned this pull request Dec 5, 2023
Merged
4 tasks
@thorn0 thorn0 merged commit 2ca5d75 into prettier:main Dec 5, 2023
@thorn0 thorn0 deleted the fix-dts-test-expect branch December 5, 2023 22:10
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 16, 2024
@thorn0 @medikoo
Fix expect call in dts test (prettier#15766)
c707e25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisker fisker fisker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thorn0 @fisker