Skip to content

Consistently use tabs in ternaries when useTabs is true #15662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sosukesuzuki merged 14 commits into from
Dec 10, 2023
Merged

Consistently use tabs in ternaries when useTabs is true #15662

sosukesuzuki merged 14 commits into from
Dec 10, 2023

Conversation

@auvred
Copy link
Contributor

@auvred auvred commented Nov 15, 2023 •
edited
Loading

Description

Fixes #15655

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker requested a review from rattrayalex November 15, 2023 12:50
rattrayalex
rattrayalex approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@rattrayalex rattrayalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, sorry about this! May have been a bad merge.

fisker
fisker reviewed Nov 17, 2023
View reviewed changes
@auvred auvred requested a review from fisker November 18, 2023 16:51
fisker
fisker reviewed Nov 19, 2023
View reviewed changes
sosukesuzuki
sosukesuzuki requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review again

@auvred auvred requested a review from sosukesuzuki November 25, 2023 11:58
sosukesuzuki
sosukesuzuki approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sosukesuzuki sosukesuzuki merged commit 0d1ffb3 into prettier:main Dec 10, 2023
@paescuj paescuj mentioned this pull request Dec 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rattrayalex rattrayalex rattrayalex approved these changes

@fisker fisker fisker approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

+1 more reviewer

@ehoogeveen-medweb ehoogeveen-medweb ehoogeveen-medweb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ternary formatting sometimes uses spaces instead of tabs

5 participants

@auvred @fisker @rattrayalex @sosukesuzuki @ehoogeveen-medweb