Skip to content

docs: removed the entire pretty-quick section#15337

Merged
fisker merged 5 commits intoprettier:mainfrom
supratikmahato:main
Sep 14, 2023
Merged

docs: removed the entire pretty-quick section#15337
fisker merged 5 commits intoprettier:mainfrom
supratikmahato:main

Conversation

@supratikmahato
Copy link
Contributor

@supratikmahato supratikmahato commented Aug 31, 2023

Marked pretty-quick as "not actively maintained" in precommit section and recommended lint-staged instead

Description

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@supratikmahato
Copy link
Contributor Author

supratikmahato commented Sep 6, 2023

Maintainers forgot about this Pull Request it seems like

@fisker
Copy link
Member

fisker commented Sep 13, 2023

Maintainers forgot about this Pull Request it seems like

We didn't, I've try to contact @azz, but he didn't repond.
If it can't work with Prettier 3, we should just remove it.

@supratikmahato
Copy link
Contributor Author

supratikmahato commented Sep 13, 2023

Ok sure

@supratikmahato
Copy link
Contributor Author

supratikmahato commented Sep 13, 2023

But wouldn't it be difficult for prettier v2 users to figure out why isn't pretty-quick working with v3?
I mean there should be some information regarding that in the documentation.

@sosukesuzuki
Copy link
Contributor

sosukesuzuki commented Sep 13, 2023 •
edited
Loading

I'm upvoting this PR since pretty-quick does not support Prettier async API (ref: https://github.com/azz/pretty-quick/blob/56e166ddfacfaa88667068b2ef7200c24ec13489/src/processFiles.js#L29 ) and there's no response from the maintainer.

I would even think it would be better to remove the section itself rather than adding "not actively maintained".

@supratikmahato
Copy link
Contributor Author

supratikmahato commented Sep 13, 2023

Ok

@supratikmahato supratikmahato changed the title docs: marked pretty-quick as "not actively maintained" in precommit section and recommended lint-staged instead docs: removed the entire pretty-quick section Sep 14, 2023
@supratikmahato supratikmahato changed the title docs: removed the entire pretty-quick section docs: removed the entire pretty-quick section Sep 14, 2023
@fisker
Copy link
Member

fisker commented Sep 14, 2023

@TechGenius7777 Can you copy changes to website/versioned_docs/version-stable/precommit.md too?

@fisker
Copy link
Member

fisker commented Sep 14, 2023

I can't edit your main branch, you can edit the file yourself, you can also merge https://github.com/TechGenius7777/prettier/pull/1

@fisker fisker merged commit 721a050 into prettier:main Sep 14, 2023
@supratikmahato
Copy link
Contributor Author

supratikmahato commented Sep 20, 2023

Thank you!

medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 16, 2024
@supratikmahato @fisker @medikoo
docs: removed the entire pretty-quick section (prettier#15337)
a47eba9 
Co-authored-by: fisker Cheung <[email protected]>
@taylorkline
Copy link

taylorkline commented Jun 3, 2024

pretty-quick has been working again since prettier/pretty-quick#182

Should pretty-quick be added back as a recommendation to the docs?

This was referenced Jun 3, 2024
Merged
Closed
JounQin added a commit to JounQin/prettier that referenced this pull request Mar 6, 2025
@JounQin
docs: add pretty-quick section back
b296858 
follow prettier#15337
@JounQin JounQin mentioned this pull request Mar 6, 2025
Merged
4 tasks
JounQin added a commit to JounQin/prettier that referenced this pull request Mar 6, 2025
@JounQin
docs: add pretty-quick section back
696a3a9 
follow prettier#15337
JounQin added a commit to JounQin/prettier that referenced this pull request Mar 6, 2025
@JounQin
docs: add pretty-quick section back
1cc2bf7 
follow prettier#15337
sosukesuzuki added a commit that referenced this pull request Mar 10, 2025
@JounQin @sosukesuzuki
docs: add pretty-quick section back (#17214)
6f48262 
* docs: add pretty-quick section back

follow #15337

* 更新 precommit.md

Co-authored-by: SUZUKI Sosuke <[email protected]>

---------

Co-authored-by: SUZUKI Sosuke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisker fisker fisker approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@supratikmahato @fisker @sosukesuzuki @taylorkline