Remove space after pipe name#14961
Merged
sosukesuzuki merged 4 commits intoprettier:mainfrom Jul 2, 2023
waterplea:fix-13887
Merged
Remove space after pipe name#14961sosukesuzuki merged 4 commits intoprettier:mainfrom waterplea:fix-13887
sosukesuzuki merged 4 commits intoprettier:mainfrom
waterplea:fix-13887
Conversation
Splaktar
reviewed
Jun 21, 2023
Comment on lines
105
to
106
| | pipeA | ||
| : { |
There was a problem hiding this comment.
Why not this for consistency?
Suggested change
| | pipeA | |
| : { | |
| | pipeA: | |
| { |
Contributor
Author
There was a problem hiding this comment.
I just rolled back how prettier treated the first semicolon. I guess this is how it used to work.
demensky
approved these changes
Jun 22, 2023
added 2 commits
July 3, 2023 02:12
sosukesuzuki
approved these changes
Jul 2, 2023
Contributor
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
@waterplea Thank you for this PR. I've updated the changelog. I'm not familiar with Angular and its community, so I trust you.
Member
|
@sosukesuzuki Can this be ported into v2? |
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Feb 15, 2024
* Remove space after pipe name * Add changelog * Update changelog * Update changelog --------- Co-authored-by: Sosuke Suzuki <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per discussion in the linked issue, the most desired format was to keep spaces around semicolon separating pipe arguments, but remove space after pipe name.
Closes #13887
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨