Transform .at to property access to improve performance
#14590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 26, 2023 03:23
sosukesuzuki
commented
Mar 25, 2023
scripts/build/shims/at.js
Outdated
| return object.at | ||
| ? object.at(index) | ||
| : object[index < 0 ? object.length + index : index]; | ||
| if (Array.isArray(object)) { |
Contributor
Author
There was a problem hiding this comment.
I am wondering if we should include brand checking for safety...
Member
There was a problem hiding this comment.
.at not only available on array, but we can check array and string only for now. We probably won't use TypedArray, and the transform only works for files (not packages) now.
prettier/scripts/build/transform/index.js
Line 13 in 4edb68a
fisker
changed the title
Array.prototype.at transform.at to property access to improve performance
Member
|
Change this back to |
fisker
approved these changes
Mar 25, 2023
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Feb 13, 2024
…4590) Co-authored-by: fisker Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address #13142 (comment)
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨