Skip to content

Update plugin build system #14571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fisker merged 25 commits into from
Mar 24, 2023
Merged

Update plugin build system #14571

fisker merged 25 commits into from
Mar 24, 2023

Conversation

@fisker
Copy link
Member

@fisker fisker commented Mar 23, 2023

Description

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker changed the title Update build system Update plugin build system Mar 23, 2023
fisker
fisker commented Mar 23, 2023
View reviewed changes
tests/dts/unit/run.js
.filter((file) => (isProduction ? true : file !== "parsers.ts"))
// Disabled due to OOM issue
// .filter((file) => (isProduction ? true : file !== "parsers.ts"))
.filter((file) => file !== "parsers.ts")
Copy link
Member Author

@fisker fisker Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sosukesuzuki

This takes me long time to figure out the problem. CI failed log

Is it possible to test with tsd or something else?

Copy link
Contributor

@sosukesuzuki sosukesuzuki Mar 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also considered tsd, but it subtly did not fit our use case. I will consider other way.

@fisker fisker marked this pull request as ready for review March 23, 2023 13:32
@fisker fisker merged commit 6d21de1 into prettier:next Mar 24, 2023
@fisker fisker deleted the build-update branch March 24, 2023 00:44
@fisker fisker mentioned this pull request Mar 24, 2023
Open
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 13, 2024
@fisker @medikoo
Update plugin build system (prettier#14571)
5643efd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker @sosukesuzuki