Skip to content

Support parse void element in vue #14560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fisker merged 13 commits into from
Mar 24, 2023
Merged

Support parse void element in vue #14560

fisker merged 13 commits into from
Mar 24, 2023

Conversation

@fisker
Copy link
Member

@fisker fisker commented Mar 22, 2023

Description

vue parser should be able to parse normal htmls.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as draft March 22, 2023 10:43
@fisker
Copy link
Member Author

fisker commented Mar 22, 2023

Something wrong.

@fisker
Copy link
Member Author

fisker commented Mar 22, 2023

Problem is we checked if (rootNodes.some(shouldParseAsHTML)) { but not checking void element.

@fisker fisker requested a review from sosukesuzuki March 22, 2023 11:50
@fisker fisker marked this pull request as ready for review March 22, 2023 12:01
@fisker fisker merged commit 94660f6 into prettier:next Mar 24, 2023
@fisker fisker deleted the vue-void-element branch March 24, 2023 06:51
sosukesuzuki
sosukesuzuki reviewed Mar 25, 2023
View reviewed changes
Copy link
Contributor

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay review, LGTM

medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 13, 2024
@fisker @medikoo
Support parse void element in vue (prettier#14560)
7cb338a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker @sosukesuzuki