Skip to content

Perf: Skip printComments if printer don't have printComment function#14468

Merged
fisker merged 4 commits intoprettier:nextfrom
fisker:print-comments-skip
Mar 24, 2023
Merged

Perf: Skip printComments if printer don't have printComment function#14468
fisker merged 4 commits intoprettier:nextfrom
fisker:print-comments-skip

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Mar 7, 2023

Description

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

Comment thread src/main/comments/print.js Outdated
// Propagate object labels so that the printing logic for ancestor nodes
// could easily check them.
typeof doc.label === "object" && { commented: true, ...doc.label },
doc.label,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thorn0 commented seems not used. Not sure why added in #13532. I think it's safe to use directly.

@fisker fisker merged commit ad9fd35 into prettier:next Mar 24, 2023
@fisker fisker deleted the print-comments-skip branch March 24, 2023 06:25
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant