Skip to content

Improve JSON parse error #14398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fisker merged 4 commits into from
Feb 24, 2023
Merged

Improve JSON parse error #14398

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4a0ea1
Add tests
fisker Feb 22, 2023
37d30c4
Better message
fisker Feb 22, 2023
1db255e
Override `MissingOneOfPlugins`
fisker Feb 22, 2023
350a720
Typo
fisker Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better message
  • Loading branch information
@fisker
fisker committed Feb 22, 2023
commit 37d30c48f6e90490f67596b6168bf59643058e99
7 changes: 7 additions & 0 deletions src/language-json/parser-json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ function createJsonParse(options = {}) {
ranges: true,
});
} catch (error) {
if (error?.reasonCode === "MissingPlugin") {
throw createBabelParseError({
message: "Unexpected token",
loc: error.loc,
});
}

throw createBabelParseError(error);
}

Expand Down
32 changes: 16 additions & 16 deletions tests/format/misc/errors/json/__snapshots__/jsfmt.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ exports[`snippet: #3 [json] format 1`] = `
`;

exports[`snippet: #3 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "doExpressions". (1:2)
"Unexpected token (1:2)
> 1 | [do {}]
| ^"
`;
Expand Down Expand Up @@ -175,7 +175,7 @@ exports[`snippet: #7 [json] format 1`] = `
`;

exports[`snippet: #7 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "functionSent". (1:24)
"Unexpected token (1:24)
> 1 | [function*() {function.sent}]
| ^"
`;
Expand All @@ -199,7 +199,7 @@ exports[`snippet: #8 [json] format 1`] = `
`;

exports[`snippet: #8 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "throwExpressions". (1:2)
"Unexpected token (1:2)
> 1 | [throw {}]
| ^"
`;
Expand All @@ -223,7 +223,7 @@ exports[`snippet: #9 [json] format 1`] = `
`;

exports[`snippet: #9 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "partialApplication". (1:6)
"Unexpected token (1:6)
> 1 | [foo(?)]
| ^"
`;
Expand Down Expand Up @@ -271,7 +271,7 @@ exports[`snippet: #11 [json] format 1`] = `
`;

exports[`snippet: #11 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "importAssertions". (1:28)
"Unexpected token (1:28)
> 1 | [import('a', {type:'json'})]
| ^"
`;
Expand All @@ -295,7 +295,7 @@ exports[`snippet: #12 [json] format 1`] = `
`;

exports[`snippet: #12 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "decimal". (1:3)
"Unexpected token (1:3)
> 1 | [1m]
| ^"
`;
Expand All @@ -319,7 +319,7 @@ exports[`snippet: #13 [json] format 1`] = `
`;

exports[`snippet: #13 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "moduleBlocks". (1:2)
"Unexpected token (1:2)
> 1 | [module {}]
| ^"
`;
Expand All @@ -343,7 +343,7 @@ exports[`snippet: #14 [json] format 1`] = `
`;

exports[`snippet: #14 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "doExpressions". (1:8)
"Unexpected token (1:8)
> 1 | [async do {}]
| ^"
`;
Expand All @@ -367,7 +367,7 @@ exports[`snippet: #15 [json] format 1`] = `
`;

exports[`snippet: #15 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "regexpUnicodeSets". (1:6)
"Unexpected token (1:6)
> 1 | [/a/v]
| ^"
`;
Expand All @@ -391,7 +391,7 @@ exports[`snippet: #16 [json] format 1`] = `
`;

exports[`snippet: #16 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "destructuringPrivate". (1:28)
"Unexpected token (1:28)
> 1 | [class {#foo;bar() {const {#foo: foo} = this;}}]
| ^"
`;
Expand All @@ -415,7 +415,7 @@ exports[`snippet: #17 [json] format 1`] = `
`;

exports[`snippet: #17 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "decoratorAutoAccessors". (1:18)
"Unexpected token (1:18)
> 1 | [class {accessor foo = 1}]
| ^"
`;
Expand All @@ -439,7 +439,7 @@ exports[`snippet: #18 [json] format 1`] = `
`;

exports[`snippet: #18 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "importAssertions". (1:34)
"Unexpected token (1:34)
> 1 | [import('a', {reflect: 'module'})]
| ^"
`;
Expand Down Expand Up @@ -487,7 +487,7 @@ exports[`snippet: #20 [json] format 1`] = `
`;

exports[`snippet: #20 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "explicitResourceManagement". (1:16)
"Unexpected token (1:16)
> 1 | [function() { {using a = b} }]
| ^"
`;
Expand Down Expand Up @@ -565,7 +565,7 @@ exports[`snippet: #23 [json] format 1`] = `
`;

exports[`snippet: #23 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "recordAndTuple". (1:2)
"Unexpected token (1:2)
> 1 | [#{}]
| ^"
`;
Expand Down Expand Up @@ -613,7 +613,7 @@ exports[`snippet: #25 [json] format 1`] = `
`;

exports[`snippet: #25 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "pipelineOperator". (1:8)
"Unexpected token (1:8)
> 1 | ['foo' |> bar]
| ^"
`;
Expand All @@ -637,7 +637,7 @@ exports[`snippet: #26 [json] format 1`] = `
`;

exports[`snippet: #26 [json] format 2`] = `
"This experimental syntax requires enabling the parser plugin: "pipelineOperator". (1:8)
"Unexpected token (1:8)
> 1 | ['foo' |> bar(%)]
| ^"
`;
Expand Down