Skip to content

Fix incorrect removal of parentheses when using an infer with a constraint in a function predicate #14279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fisker merged 5 commits into from
Feb 6, 2023
Merged

Fix incorrect removal of parentheses when using an infer with a constraint in a function predicate #14279

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86acf97
fix: paren shouldn't be removed from infer func
fisker Jan 31, 2023
ffe71f8
Simplify logic
fisker Jan 31, 2023
467a158
Test `TSConstructorType`
fisker Jan 31, 2023
ac1aac1
Put more stuff inside
fisker Jan 31, 2023
6117e1b
Revert "Put more stuff inside"
fisker Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Put more stuff inside
  • Loading branch information
@fisker
fisker committed Jan 31, 2023
commit ac1aac1146d57317cbfc4edebe2907f7fd9b238e
16 changes: 16 additions & 0 deletions tests/format/typescript/conditional-types/__snapshots__/jsfmt.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,13 @@ printWidth: 80
type Foo<T> = T extends ((...a: any[]) => infer R extends string) ? R : never;
type Foo<T> = T extends (new (...a: any[]) => infer R extends string) ? R : never;

// Nest
type Foo<T> = T extends (
(...a: any[]) => infer R extends (
T extends ((...a: any[]) => infer R extends string) ? R : never
)
) ? R : never;

// #14275
type Test<T> = T extends ((
token: TSESTree.Token
Expand All @@ -452,6 +459,15 @@ type Foo<T> = T extends (new (...a: any[]) => infer R extends string)
? R
: never;

// Nest
type Foo<T> = T extends ((
...a: any[]
) => infer R extends T extends ((...a: any[]) => infer R extends string)
? R
: never)
? R
: never;

// #14275
type Test<T> = T extends ((
token: TSESTree.Token
Expand Down
7 changes: 7 additions & 0 deletions tests/format/typescript/conditional-types/parentheses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
type Foo<T> = T extends ((...a: any[]) => infer R extends string) ? R : never;
type Foo<T> = T extends (new (...a: any[]) => infer R extends string) ? R : never;

// Nest
type Foo<T> = T extends (
(...a: any[]) => infer R extends (
T extends ((...a: any[]) => infer R extends string) ? R : never
)
) ? R : never;

// #14275
type Test<T> = T extends ((
token: TSESTree.Token
Expand Down