Refactor interface body and object type print#14111
Merged
fisker merged 19 commits intoprettier:mainfrom Oct 22, 2025
Merged
Conversation
Member
|
Interface bodies and object types are exactly the same syntax (interfaces essentially are named object types), so #14040 is a bug in object types too (playground), and using different code paths to print them is probably not the right thing to do. |
Member
Author
|
I noticed |
Member
Author
|
It seems we always break |
| bar /* foo */ /* bar */?(/* baz */) /* bat */; | ||
| bar2 /* foo */(/* baz */) /* bat */; | ||
| bar /* foo */ /* bar */?(/* baz */); /* bat */ | ||
| bar2 /* foo */(/* baz */); /* bat */ |
There was a problem hiding this comment.
Is this change in the output intended?
Member
Author
There was a problem hiding this comment.
I think so,
Prettier 2.8.2
Playground link
--parser typescriptInput:
interface foo1 {
bar /* bat */;
bar ;/* bat */
}
class foo1 {
bar /* bat */;
bar ;/* bat */
}
Output:
interface foo1 {
bar /* bat */;
bar /* bat */;
}
class foo1 {
bar /* bat */;
bar; /* bat */
}
fisker
force-pushed
the
ts-interface-body
branch
from
86cba63 to
d5cdaf7
Compare
commit: |
✅ Deploy Preview for prettier ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fisker
changed the title
TSInterfaceBody print
This was referenced Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TSInterfaceBodyshould use the same logic asClassBody.To fix #14040, we can introduce similar logic as
shouldPrintSemicolonAfterClassPropertyafter this get merged.//cc @thorn0
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨