Skip to content

Support "Import Reflection" proposal#13771

Merged
fisker merged 6 commits intoprettier:nextfrom
fisker:import-reflection
Nov 7, 2022
Merged

Support "Import Reflection" proposal#13771
fisker merged 6 commits intoprettier:nextfrom
fisker:import-reflection

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Oct 31, 2022

Description

Ref #13750

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker mentioned this pull request Oct 31, 2022
3 tasks
@@ -0,0 +1,9 @@
#### Add support for "Import Reflection" proposal (#13771 by @fisker)

The Stage 2 proposal ["Import Reflection"](https://github.com/tc39/proposal-import-reflection) is now supported via Babel 7.20.0. Also keep in mind our [policy on non-standardized syntax](https://github.com/tc39/proposal-explicit-resource-management/) before using this proposed syntax feature with Prettier.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why link policy on non-standardized syntax to proposal-explicit-resource-management?😕

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-pasted from old changelog.

@fisker fisker force-pushed the import-reflection branch from bf6d8c5 to 9f5f8a7 Compare November 2, 2022 01:56
@fisker fisker changed the title Support "Import reflection" proposal Support "Import Reflection" proposal Nov 2, 2022
@fisker fisker marked this pull request as ready for review November 2, 2022 02:03
@kachkaev
Copy link
Copy Markdown
Member

kachkaev commented Nov 6, 2022

@fisker WDYT of including this into 2.8?

@sosukesuzuki
Copy link
Copy Markdown
Contributor

I don't think we need to add this to 2.8 because this is a still experimental ECMAScript feature and almost users don't need this.

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 6, 2022

Agree

@fisker fisker force-pushed the import-reflection branch from db2584d to 124486e Compare November 7, 2022 01:29
@fisker fisker merged commit 1de926a into prettier:next Nov 7, 2022
@fisker fisker deleted the import-reflection branch November 7, 2022 01:49
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants