Upgrade to latest remark version#13676
Conversation
|
Have you seen #12209 (comment)? |
|
I definitely saw it when it was posted but forgot about it. Closing since they're working on it and will probably do a better job than me :) |
|
See #12209 I would love to help out if you decide to continue this PR and have any questions. My first suggestion is: add |
7ab0828 to
331c737
Compare
25af755 to
84bb376
Compare
84bb376 to
4614b89
Compare
a535b30 to
a879205
Compare
*only 1 tho
|
@j-f1 I think I have made great progress here now. In this PR, let's focus on the markdown parsing, I kept the I've created @seiyab Thanks for the liquid plugin from #16134 We still need go through the test changes to make sure they are right. I'm not going to continue work on this recently. Welcome to continue the work or review if interested. @j-f1 @seiyab @remcohaszing @tats-u
|
|
Thank you for your work. |
|
The AST_COMPARE test can test if the AST changed. Eg: https://github.com/prettier/prettier/actions/runs/9626611049/job/26552757384?pr=13676#step:6:2509 |
|
Sounds good! But maybe some wrong parsing can be missed? (technically unchanged wrong AST can exist) |
|
I would put some faith in the parser that it produces correct ASTs. |
|
@fisker |
You can do that |
|
I'm sorry but I'm not working on this now. |
|
Continue in #18277 |
Description
Updgrades to latest Remark and tweaks our custom parsing things to work with it.
TODO
MDXTypeError: Cannot read properties of undefined (reading '1') at subcontent (/micromark-util-subtokenize/index.js:165:35)Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨
✨ playground (Markdown)✨