Skip to content

Sync commonmark spec examples#13642

Closed
fisker wants to merge 10 commits intoprettier:mainfrom
fisker:commonmark-spec-test
Closed

Sync commonmark spec examples#13642
fisker wants to merge 10 commits intoprettier:mainfrom
fisker:commonmark-spec-test

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Oct 14, 2022

Description

Fixes #13591

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker force-pushed the commonmark-spec-test branch from 4174702 to a68614c Compare October 14, 2022 13:46
@kachkaev
Copy link
Copy Markdown
Member

WDYT of switching to commonmark-0.30-example-xxx.md for file names? If we stick with example-xxx.md, git will detect files as modified instead of renamed each time examples are shifted in a new spec. Diff will be cleaner with file prefix.

@fisker fisker force-pushed the commonmark-spec-test branch from a68614c to 7d33e0b Compare October 17, 2022 02:55
@fisker
Copy link
Copy Markdown
Member Author

fisker commented Oct 22, 2022

Let's do this after #13676

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 24, 2022

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 24, 2022

create-gfm-fixtures can be useful too.

@fisker fisker changed the base branch from next to main April 23, 2023 01:17
@fisker fisker mentioned this pull request Dec 5, 2025
4 tasks
@fisker fisker closed this in #18428 Dec 5, 2025
@fisker fisker deleted the commonmark-spec-test branch December 5, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown spec examples need updating in tests

2 participants