Remove prettier.doc.builders.concat#13203
Merged
fisker merged 13 commits intoprettier:nextfrom Aug 6, 2022
Merged
Conversation
Member
Author
|
Should we remove it "softly" |
sosukesuzuki
reviewed
Aug 1, 2022
Contributor
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
Update commands.md and add changelog?
sosukesuzuki
approved these changes
Aug 2, 2022
# Conflicts: # src/language-html/printer-html.js
Member
Author
Member
Yes, let's do this. |
Member
|
Otherwise for many plugins it might be the only breaking change. With this soft deprecation, there is a good change those plugins won't need to be changed at all. |
thorn0
approved these changes
Aug 5, 2022
Member
Author
|
Should we change this line prettier/src/document/constants.js Line 2 in e096ea7 to anther string? Otherwise, {
type: 'concat'
}Will pass the doc type check, but fail when calling array methods. |
Member
|
Let's use "array". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref #13142
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨