Skip to content

Conversation

@fisker
Copy link
Member

@fisker fisker commented Aug 1, 2022

Description

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker mentioned this pull request Aug 1, 2022
23 tasks
@fisker fisker marked this pull request as ready for review August 1, 2022 09:45
Copy link
Contributor

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

return { name, ...plugin };
} catch {
// try node modules
return importPlugin(name, process.cwd());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be covered by tests..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 100% sure this line is covered, there is something wrong with c8, see nicolo-ribaudo/jest-light-runner#13

fisker added 2 commits August 3, 2022 18:57
# Conflicts:
#	tests/integration/plugins/automatic/prettier-plugin-baz.js
@JounQin JounQin mentioned this pull request Aug 4, 2022
@fisker fisker merged commit 5aadab6 into prettier:next Aug 6, 2022
@fisker fisker deleted the esm-plugins branch August 6, 2022 02:42
fisker added a commit to fisker/prettier that referenced this pull request Apr 4, 2023
@fisker fisker mentioned this pull request Apr 4, 2023
4 tasks
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants