Skip to content

Set trailingComma default value to all #13143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sosukesuzuki wants to merge 8 commits into from
Closed

Set trailingComma default value to all #13143

sosukesuzuki wants to merge 8 commits into from

Conversation

@sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Jul 20, 2022 •
edited
Loading

Description

Fixes #11465

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@sosukesuzuki sosukesuzuki mentioned this pull request Jul 20, 2022
Closed
23 tasks
@sosukesuzuki
Copy link
Contributor Author

sosukesuzuki commented Jul 20, 2022

Need to update snapshots of integration tests, so wait #12859

@fisker
Copy link
Member

fisker commented Jul 20, 2022

You can do yarn build && yarn test:dist -u

@sosukesuzuki sosukesuzuki requested a review from fisker July 21, 2022 00:53
@fisker
Copy link
Member

fisker commented Jul 21, 2022 •
edited
Loading

  1. Don't duplicate tests, we don't need so many tests for "es5" and "none".
  2. Try to keep the output in original order, so in the snapshots, only "header"/"options" will change, the code won't change

The diff should close to this number
image

#6963

I think I already did needed changes in #11479, maybe we start over from there?

@sosukesuzuki
Copy link
Contributor Author

sosukesuzuki commented Jul 23, 2022

I think I already did needed changes in #11479, maybe we start over from there?

Oops, I didn't notice your PR! We can close this my PR!

fisker added a commit to fisker/prettier that referenced this pull request Jul 23, 2022
@fisker
Copy changelog from prettier#13143
d323c43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisker fisker Awaiting requested review from fisker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sosukesuzuki @fisker