Skip to content

Conversation

@fisker
Copy link
Member

@fisker fisker commented Jul 18, 2022

Description

Fixes #12701

Not ready yet, seems can't test...

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker mentioned this pull request Jul 18, 2022
4 tasks
@fisker fisker mentioned this pull request Jul 19, 2022
4 tasks
@sosukesuzuki sosukesuzuki mentioned this pull request Jul 20, 2022
23 tasks
fisker added 2 commits July 21, 2022 11:09
# Conflicts:
#	src/config/get-prettier-config-explorer.js
@fisker fisker mentioned this pull request Jul 21, 2022
4 tasks
@fisker fisker marked this pull request as ready for review July 21, 2022 10:10
@sosukesuzuki sosukesuzuki self-requested a review July 23, 2022 06:00
Copy link
Contributor

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! What do you think about to migrate our ./.prettierrc (yaml) to ./.prettierrc.js (ESM) as dog fooding?

@fisker
Copy link
Member Author

fisker commented Aug 1, 2022

What do you think about to migrate our ./.prettierrc (yaml) to ./.prettierrc.js (ESM) as dog fooding?

We can't do that until we release this change, we are using stable version of Prettier.

@fisker fisker merged commit 44d246a into prettier:next Aug 1, 2022
@fisker fisker deleted the esm-config-mjs branch August 1, 2022 18:19
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 17, 2024
marmitar added a commit to marmitar/thelounge that referenced this pull request Nov 4, 2025
Code formatted automatically, see <https://prettier.io/blog/2023/07/05/3.0.0>.

Support for config files in ESM (prettier/prettier#13130).

Remove deprecated `disableLanguages` option for VSCode Extension
(prettier/prettier-vscode@5d69543).
marmitar added a commit to marmitar/thelounge that referenced this pull request Nov 17, 2025
Code formatted automatically, see <https://prettier.io/blog/2023/07/05/3.0.0>.

Support for config files in ESM (prettier/prettier#13130).

Remove deprecated `disableLanguages` option for VSCode Extension
(prettier/prettier-vscode@5d69543).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants