-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Support config file in ESM #13130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support config file in ESM #13130
Conversation
# Conflicts: # src/config/get-prettier-config-explorer.js
# Conflicts: # tests/integration/__tests__/config-resolution.js
sosukesuzuki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! What do you think about to migrate our ./.prettierrc (yaml) to ./.prettierrc.js (ESM) as dog fooding?
We can't do that until we release this change, we are using stable version of Prettier. |
# Conflicts: # yarn.lock
Code formatted automatically, see <https://prettier.io/blog/2023/07/05/3.0.0>. Support for config files in ESM (prettier/prettier#13130). Remove deprecated `disableLanguages` option for VSCode Extension (prettier/prettier-vscode@5d69543).
Code formatted automatically, see <https://prettier.io/blog/2023/07/05/3.0.0>. Support for config files in ESM (prettier/prettier#13130). Remove deprecated `disableLanguages` option for VSCode Extension (prettier/prettier-vscode@5d69543).
Description
Fixes #12701
Not ready yet, seems can't test...Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨