Fix integration test #12859
Merged
Fix integration test #12859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/integration/__tests__/bundle.js # tests/integration/__tests__/help-options.js # tests/integration/__tests__/infer-parser.js # tests/integration/cli-worker.js
# Conflicts: # tests/integration/__tests__/early-exit.js # tests/integration/__tests__/infer-parser.js # tests/integration/__tests__/parser-api.js # tests/integration/__tests__/support-info.js # tests/integration/__tests__/with-parser-inference.js
fisker
changed the title
jest-light-runner
14 tasks
This reverts commit 52c90b2.
fisker
commented
Jul 19, 2022
package.json
Outdated
| "execa": "6.1.0", | ||
| "jest": "28.1.0", | ||
| "jest-light-runner": "0.2.2", | ||
| "jest-light-runner": "fisker/jest-light-runner#fix-addSnapshotSerializer", |
Member
Author
There was a problem hiding this comment.
This was referenced Jul 19, 2022
Closed
| "execa": "6.1.0", | ||
| "jest": "28.1.0", | ||
| "jest-light-runner": "0.2.2", | ||
| "jest-light-runner": "fisker/jest-light-runner#b5e893d3a7d301bfb5d68ed81eebadbe2bb0577d", |
Contributor
There was a problem hiding this comment.
Just a question, what is a difference between I missed #12859 (comment)jest-light-runnner and your fork?
| import jestPathSerializer from "../path-serializer.js"; | ||
|
|
||
| const { require } = createEsmUtils(import.meta); | ||
| const { require, importModule } = createEsmUtils(import.meta); |
Contributor
There was a problem hiding this comment.
What is the diff between import and importModule?
Member
Author
There was a problem hiding this comment.
importModule = import(url.pathToFileURL()) on windows the argument must be a URL
4 tasks
Member
Author
|
@sosukesuzuki I accidentally changed the fixtures for --cache test, but test still passed 20d63ec, also this test changes files and create directories during test, I accidentally committed them several times, I think better use a temp dir to run them, do you think you can do that? |
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Jan 16, 2024
fisker
added a commit
to fisker/prettier
that referenced
this pull request
Feb 16, 2025
Removed from prettier#12859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨