Ignore cursorOffset in format() and check()
#12803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
reviewed
May 7, 2022
| const { formatted } = await formatWithCursor(text, opts); | ||
| async function format(text, options) { | ||
| const { formatted } = await formatWithCursor(text, { | ||
| ...options, |
Contributor
There was a problem hiding this comment.
I don't think we should use spread syntax for this because copying is little expensive. Can we use options.cursorOffset = -1?
Member
Author
There was a problem hiding this comment.
I don't think so, this option is user input, we shouldn't modify it. It can also be undefined.
Member
Author
There was a problem hiding this comment.
I don't think clone an object is that expensive.
sosukesuzuki
approved these changes
May 8, 2022
4 tasks
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maintain
cursorOffsetseems expensive to me, and it's useless informat()andcheck()Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨