Preserve empty lines in CSS/SCSS paren groups#12210
Merged
duailibe merged 3 commits intoprettier:mainfrom Feb 2, 2022
Merged
Conversation
duailibe
force-pushed
the
css-empty-line
branch
from
1c14268 to
3ceea0e
Compare
duailibe
force-pushed
the
css-empty-line
branch
from
3ceea0e to
24eba53
Compare
sosukesuzuki
reviewed
Feb 2, 2022
Contributor
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
Can you add tests for multi empty lines?
Prettier pr-12210
Playground link
--parser scssInput:
$colours: (
"text": $light-100,
"background-primary": $dark-300,
"background-secondary": $dark-200,
"background-tertiary": $dark-100
);Output:
$colours: (
"text": $light-100,
"background-primary": $dark-300,
"background-secondary": $dark-200,
"background-tertiary": $dark-100,
);
sosukesuzuki
reviewed
Feb 2, 2022
sosukesuzuki
approved these changes
Feb 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #12053, will improve the comment placement from the example in another PR
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨