Markdown[next branch]: Do not insert spaces between Chinese/Japanese & latin letters by tats-u · Pull Request #11597 · prettier/prettier

tats-u · 2021-09-30T05:52:56Z

Description

This PR is for fixing #6385 in the coming version 3.0, and introduces the change in my hotfix plugin to the original Prettier.
Remove the option from and optimize #8526

Note: this is for the next branch, not the main branch.

If I do not have to add anything in changelog_unreleased/markdown/, I will change this to the normal (not draft) PR.

Fixes #6385

Checklist

I’ve added tests to confirm my change works.
(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
(If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
I’ve read the contributing guidelines.

✨Try the playground for this PR✨

I just did yarn jest --updateSnapshot.

P.S. (2022-12-11)
This patch is enabled in Prettier 3.0.0-alpha.3 or later.

sosukesuzuki

If I do not have to add anything in changelog_unreleased/markdown/, I will change this to the normal (not draft) PR.

This PR needs changelog! Please add it.

tats-u · 2021-10-01T11:59:52Z

@sosukesuzuki I added one. It may have wrong usage of English words.

tats-u · 2021-10-04T13:32:20Z

This is not compatible with the current CI (lint). The stable version must not be used to check my changelog. This contains “第1章” (means Chapter 1), which will be spoiled (2x U+0020 will be inserted) by it. I cannot help it.

prettier/package.json

Line 90 in 04391a0

"devDependencies": {

prettier/package.json

Line 131 in 04391a0

"prettier": "2.4.0",

prettier/package.json

Line 141 in 04391a0

"scripts": {

prettier/package.json

Line 156 in 04391a0

"lint:prettier": "prettier . \"!test*\" --check",

prettier/.github/workflows/lint.yml

Lines 36 to 37 in 04391a0

    
           - name: Lint Prettier 
        
             run: yarn lint:prettier

tats-u · 2021-10-04T14:00:24Z

I wish we could test code not only by prettier . "!test*" --check but also by node ./dist/bin-prettier.js . "!test*" --check.

tats-u · 2021-10-04T14:14:11Z

Another plan is to use my patch plugin prettier-plugin-md-nocjsp to lint only my changelog.
We only have to add it to devDependencies and .prettierrc to changelog_unreleased/markdown.

overrides:
  - files:
      - 11597.md
    options:
      parser: markdown-nocjsp

tats-u · 2021-10-17T13:06:45Z

https://github.com/prettier/prettier/pull/11597/checks?check_run_id=3918774427

Another new PR is required.

This is not compatible with the current CI (lint). The stable version must not be used to check my changelog. This contains “第1章” (means Chapter 1), which will be spoiled (2x U+0020 will be inserted) by it. I cannot help it.

prettier/package.json

Line 90 in 04391a0

"devDependencies": {

prettier/package.json

Line 131 in 04391a0

"prettier": "2.4.0",

prettier/package.json

Line 141 in 04391a0

"scripts": {

prettier/package.json

Line 156 in 04391a0

"lint:prettier": "prettier . \"!test*\" --check",

prettier/.github/workflows/lint.yml

Lines 36 to 37 in 04391a0

- name: Lint Prettier

run: yarn lint:prettier

The current CI tries to use the stable version of Prettier to lint.
We have to force the CI to use bin/prettier.js at least in the next branch and its derivatives.

tats-u · 2021-10-24T11:05:25Z

Fixed by adding one more . Who do I have to ask to check and approve my changes?

<!-- prettier-ignore -->
Adding whitespace may interfere with searches for text containing both Chinese or Japanese and western characters. For example, you cannot find “第1章” (Chapter 1) in a Markdown document or its derivative just by searching by the string “第1章” but “第 1 章”.

tats-u · 2021-10-24T11:06:49Z

(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).

Do I have to do this?

tats-u · 2022-05-15T05:12:28Z

Could you tell me what prevents this PR from merged?

fisker · 2022-05-16T02:38:25Z

I think we are good to merge. Please be patient. We are still far from release v3 anyway.

fisker · 2022-10-19T08:44:25Z

Great job!

thorn0 · 2022-10-19T08:46:11Z

Thanks @tats-u ! Congrats with the end of this year-long journey. 🎉

sosukesuzuki · 2022-10-19T08:53:39Z

Great job!!!! Thank you!!

reminjp · 2022-10-19T09:08:30Z

I’m glad to hear this! Great job!!

gentksb · 2022-10-19T09:35:24Z

Extremely great job!!!

tats-u · 2022-10-19T13:16:37Z

@thorn0 @fisker Thank you for your cooperations and reviews.

kissge · 2022-10-20T00:40:34Z

Truly great work. Thanks!!

DarkGhost7 · 2022-10-20T16:24:36Z

Thanks!!

ice-kylin · 2024-02-06T19:14:24Z

Is there an option to add whitespace between Chinese and Latin characters?

fisker · 2024-02-06T19:25:41Z

No, there is no option for it, you can try https://github.com/lint-md/lint-md

Locking this PR, since it's old.

sosukesuzuki reviewed Sep 30, 2021

View reviewed changes

tats-u force-pushed the cj-alnum-nospace branch 2 times, most recently from a09c98c to a1d9b7e Compare October 1, 2021 11:57

tats-u marked this pull request as ready for review October 1, 2021 11:57

tats-u force-pushed the cj-alnum-nospace branch from a1d9b7e to 6457dcf Compare October 2, 2021 13:18

sosukesuzuki added this to the 3.0 milestone Oct 3, 2021

tats-u marked this pull request as draft October 4, 2021 13:13

tats-u force-pushed the cj-alnum-nospace branch from 6457dcf to 394b1d7 Compare October 4, 2021 13:24

tats-u marked this pull request as ready for review October 4, 2021 14:02

tats-u commented Oct 4, 2021

View reviewed changes

Comment thread changelog_unreleased/markdown/11597.md Outdated

tats-u mentioned this pull request Oct 10, 2021

[editorconfig] Turn off trim_trailing_whitespace in Markdown in root or changelog_unreleased #11605

Merged

4 tasks

tats-u force-pushed the cj-alnum-nospace branch from 394b1d7 to 8212b8e Compare October 17, 2021 12:45

tats-u mentioned this pull request Oct 17, 2021

next branch: Use souce code version of Prettier instead of latest stable one to lint source in next branch #11691

Closed

4 tasks

tats-u force-pushed the cj-alnum-nospace branch from 8212b8e to 073f7b6 Compare October 24, 2021 11:02

fisker reviewed Oct 25, 2021

View reviewed changes

Comment thread src/language-markdown/utils.js Outdated

tats-u requested review from fisker and sosukesuzuki October 25, 2021 12:26

tats-u force-pushed the cj-alnum-nospace branch from 418164d to 34e3f66 Compare May 14, 2022 14:49

fisker changed the title ~~Markdown[next branch]: Do not insert spaces between Chinese/Japanese & latin letters (#6385)~~ Markdown[next branch]: Do not insert spaces between Chinese/Japanese & latin letters May 16, 2022

fisker reviewed May 16, 2022

View reviewed changes

Comment thread changelog_unreleased/markdown/11597.md Outdated

tats-u mentioned this pull request Jul 17, 2022

Do not insert whitespaces between latin and cj letters #6385

Closed

fisker reviewed Oct 17, 2022

View reviewed changes

Comment thread src/language-markdown/print-whitespace.js Outdated

thorn0 added 4 commits October 17, 2022 19:53

Add explanatory comment about link labels

a366c9e

Refactor printWhitespace

9331a2b

Minor refactoring

5962b46

Another refactoring

82b4153

thorn0 reviewed Oct 18, 2022

View reviewed changes

Comment thread src/language-markdown/print-whitespace.js Outdated

tats-u and others added 5 commits October 19, 2022 00:05

Improve comments

cb05019

Fix comment saying opposite

7810a4f

Refactor, edit comments

0a27cbd

Refactor: more explicit parameter for links

d65be2b

Minor refactoring

4e145ae

thorn0 approved these changes Oct 18, 2022

View reviewed changes

thorn0 added 2 commits October 19, 2022 01:13

Impove types

86a41b5

Move typedefs after imports

1d703d2

thorn0 merged commit ebb8e13 into prettier:next Oct 19, 2022

tats-u deleted the cj-alnum-nospace branch October 19, 2022 13:16

kachkaev mentioned this pull request Jun 13, 2023

[v4+ / breaking change] Always treat newline between non-punctuation han/kana and alphanumeric as space when proseWrap is always #14936

Open

1 task

tats-u mentioned this pull request Sep 12, 2023

Upgrade builtin Prettier to 3.x prettier/prettier-vscode#3142

Closed

medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 6, 2024

Markdown: improve whitespace handling in CJK (prettier#11597)

e6507ef

prettier locked as resolved and limited conversation to collaborators Feb 6, 2024

Uh oh!

Conversation

tats-u commented Sep 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

sosukesuzuki left a comment

Choose a reason for hiding this comment

Uh oh!

tats-u commented Oct 1, 2021

Uh oh!

tats-u commented Oct 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tats-u commented Oct 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tats-u commented Oct 4, 2021

Uh oh!

tats-u commented Oct 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tats-u commented Oct 24, 2021

Uh oh!

tats-u commented Oct 24, 2021

Uh oh!

Uh oh!

tats-u commented May 15, 2022

Uh oh!

Uh oh!

fisker commented May 16, 2022

Uh oh!

Uh oh!

Uh oh!

fisker commented Oct 19, 2022

Uh oh!

thorn0 commented Oct 19, 2022

Uh oh!

sosukesuzuki commented Oct 19, 2022

Uh oh!

reminjp commented Oct 19, 2022

Uh oh!

gentksb commented Oct 19, 2022

Uh oh!

tats-u commented Oct 19, 2022

Uh oh!

kissge commented Oct 20, 2022

Uh oh!

DarkGhost7 commented Oct 20, 2022

Uh oh!

ice-kylin commented Feb 6, 2024

Uh oh!

fisker commented Feb 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

tats-u commented Sep 30, 2021 •

edited

Loading

tats-u commented Oct 4, 2021 •

edited

Loading

tats-u commented Oct 4, 2021 •

edited

Loading

tats-u commented Oct 17, 2021 •

edited

Loading