Fix YAML comment after an anchor doesn't stay on a separate line#11395
Open
wafuwafu13 wants to merge 2 commits intoprettier:mainfrom
Open
Fix YAML comment after an anchor doesn't stay on a separate line#11395wafuwafu13 wants to merge 2 commits intoprettier:mainfrom
wafuwafu13 wants to merge 2 commits intoprettier:mainfrom
Conversation
|
I've tried this locally and it seems good! Anything we can do to get it merged? |
Member
|
/cc @thorn0 can you look? |
thorn0
requested changes
Dec 23, 2021
| parts.push([ | ||
| node.middleComments.length === 1 ? "" : hardline, | ||
| !anchor || | ||
| (node.middleComments.length === 1 && |
Member
There was a problem hiding this comment.
Sorry for the wait. This condition looks too specific. What if there are multiple comments?
Prettier pr-11395
Playground link
--parser yamlInput:
key1: &default # comment1
# This key ...
subkey1: value1
key2:
<<: *default
key3: # comment2
# comment3
subkey3: valueOutput:
key1: &default
# comment1
# This key ...
subkey1: value1
key2:
<<: *default
key3: # comment2
# comment3
subkey3: value
| --- | ||
| !shape | ||
| # Use the ! handle for presenting | ||
| !shape # Use the ! handle for presenting |
Member
There was a problem hiding this comment.
These changes shouldn't happen. Comments that are on their own line should stay on their line, trailing comments should stay trailing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10518
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨