Print leading comment for readonly modifier of TS Mapped Types#11190
Closed
sosukesuzuki wants to merge 8 commits intoprettier:mainfrom
Closed
Print leading comment for readonly modifier of TS Mapped Types#11190sosukesuzuki wants to merge 8 commits intoprettier:mainfrom
sosukesuzuki wants to merge 8 commits intoprettier:mainfrom
Conversation
Member
|
I'm not sure if we want to do this, the current output seems more preferred for me. Prettier pr-11190 --parser babelInput: class A {
static // comment
foo() {}
get // comment
foo() {}
// comment
static
foo() {}
// comment
get
foo() {}
}Output: class A {
static // comment
foo() {}
get // comment
foo() {}
// comment
static foo() {}
// comment
get foo() {}
} |
4 tasks
Member
|
superseded by #13427 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11098
Since
TSMappedTypecontains{and}, it could not be implemented as a simple leading comments.Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨