CLI: Fix failure on dir with trailing slash #11000
Conversation
| input: pattern, | ||
| }); | ||
| } else if (stat.isDirectory()) { | ||
| const relativePath = path.relative(cwd, absolutePath) || "."; |
There was a problem hiding this comment.
If the goal of this line is only to remove trailing slashes, why not do .replace(/[/\\]+$/, '') here to express the intent more clearly?
There was a problem hiding this comment.
I think the middle one foo//bar was effected too.
There was a problem hiding this comment.
I'll confirm when I back to laptop, if it's true, I'll add comment.
There was a problem hiding this comment.
Tested, the tailing slash is the only problem, applied your suggestion.
There was a problem hiding this comment.
Your solution can't work, because \ can be the dirname, see this log https://github.com/prettier/prettier/runs/2746762536#step:6:1251
This commit da46196 works, but feel better/safer to use path.relative, added comments b009878
3 participants
Description
Fixes #9300
Fixes #10964
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨