Fix missing parentheses on async inside for..of#10781
Merged
thorn0 merged 9 commits intoprettier:mainfrom May 6, 2021
Merged
Conversation
thorn0
approved these changes
Apr 29, 2021
Member
thorn0
left a comment
thorn0
left a comment
There was a problem hiding this comment.
Strictly speaking, the parens aren't needed in for await (async of []);, but Babel can't parse it without them.
sosukesuzuki
approved these changes
Apr 29, 2021
Contributor
|
@thorn0 Has it been reported to babel/babel or fixed already in |
Member
|
@sosukesuzuki I only left a comment in babel/babel#13208, but I didn't report this issue properly. There are also issues with |
Contributor
|
@thorn0 Thank you. I'll investigate specs and report to babel/babel and fix, okay? |
Member
|
Sounds good 👍 Probably these changes in the spec are recent. |
Member
|
BTW, here is valid TypeScript that compiles to invalid JS by both the TypeScript compiler and Babel (probably fixed by babel/babel#13208): |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10777
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨