GraphQL: Fix missing space after keyword in anonymous operations#10689
Merged
thorn0 merged 2 commits intoprettier:mainfrom Apr 12, 2021
Merged
GraphQL: Fix missing space after keyword in anonymous operations#10689thorn0 merged 2 commits intoprettier:mainfrom
thorn0 merged 2 commits intoprettier:mainfrom
Conversation
patriscus
changed the title
GraphQL: Fix missing space after keyword in anonymous operations
thorn0
approved these changes
Apr 11, 2021
Member
thorn0
left a comment
thorn0
left a comment
There was a problem hiding this comment.
Looks good. Thank you for your contribution!
thorn0
reviewed
Apr 11, 2021
| @@ -0,0 +1,19 @@ | |||
| #### Fix missing space after keyword in anonymous graphql operations (#10655 by @patriscus) | |||
Member
There was a problem hiding this comment.
Could you please rename the file and specify the number of the PR here instead of the number of the issue?
Contributor
Author
There was a problem hiding this comment.
@thorn0 thanks for reviewing so promptly and sorry about the wrong number, changed it now
Add changelog
patriscus
changed the title
|
Is this expected to make it into the 2.3 release? @patriscus I think there is no need to put the PR number in the title of this PR. The GitHub UI will generally add the PR number when the PR is merged. |
patriscus
changed the title
fisker
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10655
Description
Added an additional condition to check if a space (
" ") should be inserted after the keyword.Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨