Don't use smart quotes for JSON5 with --quote-props=preserve#10323
Merged
thorn0 merged 3 commits intoprettier:mainfrom Feb 15, 2021
Merged
Don't use smart quotes for JSON5 with --quote-props=preserve#10323thorn0 merged 3 commits intoprettier:mainfrom
thorn0 merged 3 commits intoprettier:mainfrom
Conversation
fisker
approved these changes
Feb 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5708
More specifically, addresses #5708 (comment)
With the
quotePropsoption set topreserveandsingleQuotestofalse(default), double quotes are always used for printing strings, including situations like this:"bla\"bla". This effectively allows using--parser json5for "JSON with comments and trailing commas".Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨