Skip to content

Making a release with new options / 1.19.0 “post mortem” #6887

@lydell

Description

@lydell

All options in Prettier have a since: "x.y.z" field.

The new option in 1.19, vueIndentScriptAndStyle, had since: "1.19.0".

prettier --support-info apparently does not print stuff with a higher since version than is specified in package.json.

The release script bumps the version in package.json and then runs the tests. The tests for prettier --support-info then fail, because now it returns the new option added in 1.19.0 which isn’t in the snapshots.

I worked around this issue by first making a commit where I bumped the version in package.json to 1.19.0-beta.1 and updated the snapshots:

057e15d

However, we now have this in our code:

vueIndentScriptAndStyle: {
    since: "1.19.0-beta.1",

The questions of this issue are:

  • Is since: "1.19.0-beta.1" a problem? EDIT: Changed to since: "1.19.0" in 1.19.1.
  • Does the release script need updating to handle new options?
  • Should the PR adding the new vueIndentScriptAndStyle have done something differently?

@duailibe do you have any insight?

Metadata

Metadata

Assignees

Labels

locked-due-to-inactivityPlease open a new issue and fill out the template instead of commenting.type:infraIssues about CI, publishing to npm, or similartype:metaIssues about the status of Prettier, or anything else about Prettier itself

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions