-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Closed
Labels
locked-due-to-inactivityPlease open a new issue and fill out the template instead of commenting.Please open a new issue and fill out the template instead of commenting.type:infraIssues about CI, publishing to npm, or similarIssues about CI, publishing to npm, or similartype:metaIssues about the status of Prettier, or anything else about Prettier itselfIssues about the status of Prettier, or anything else about Prettier itself
Description
All options in Prettier have a since: "x.y.z" field.
The new option in 1.19, vueIndentScriptAndStyle, had since: "1.19.0".
prettier --support-info apparently does not print stuff with a higher since version than is specified in package.json.
The release script bumps the version in package.json and then runs the tests. The tests for prettier --support-info then fail, because now it returns the new option added in 1.19.0 which isn’t in the snapshots.
I worked around this issue by first making a commit where I bumped the version in package.json to 1.19.0-beta.1 and updated the snapshots:
However, we now have this in our code:
vueIndentScriptAndStyle: {
since: "1.19.0-beta.1",
The questions of this issue are:
IsEDIT: Changed tosince: "1.19.0-beta.1"a problem?since: "1.19.0"in 1.19.1.- Does the release script need updating to handle new options?
- Should the PR adding the new
vueIndentScriptAndStylehave done something differently?
@duailibe do you have any insight?
Metadata
Metadata
Assignees
Labels
locked-due-to-inactivityPlease open a new issue and fill out the template instead of commenting.Please open a new issue and fill out the template instead of commenting.type:infraIssues about CI, publishing to npm, or similarIssues about CI, publishing to npm, or similartype:metaIssues about the status of Prettier, or anything else about Prettier itselfIssues about the status of Prettier, or anything else about Prettier itself