-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
--only-changed need review again #6577
Copy link
Copy link
Closed
Labels
area:cliIssues with Prettier's Command Line InterfaceIssues with Prettier's Command Line Interfacelocked-due-to-inactivityPlease open a new issue and fill out the template instead of commenting.Please open a new issue and fill out the template instead of commenting.status:needs discussionIssues needing discussion and a decision to be made before action can be takenIssues needing discussion and a decision to be made before action can be taken
Milestone
Metadata
Metadata
Assignees
Labels
area:cliIssues with Prettier's Command Line InterfaceIssues with Prettier's Command Line Interfacelocked-due-to-inactivityPlease open a new issue and fill out the template instead of commenting.Please open a new issue and fill out the template instead of commenting.status:needs discussionIssues needing discussion and a decision to be made before action can be takenIssues needing discussion and a decision to be made before action can be taken
PR: #5910
I think we should remove revert this PR and finish the PR late, as this could potentially create problems:
eslint/stylelint(maybe other linters) use--cacheoption, so currently name is not too goodeslint/stylelintdo), it is allow to use cache for node API users (plugins for IDE, custom CLI runner, etc)--checkargument too. I don't want to recheck files what are not changed--cache(check and format only changed files, as in eslint and stylelint) can be difficult and added an additional cache layer what can be misleading and consume a lot of disk spaceIt is very important because changing CLI argumentx and logic potentially can be breaking change and we need to do good design for CLI/API to avoid unnecessary/painful problems in future and avoid unnecessary breaking change.
I can to refactor and improve it, but it is require time, and we already prepare
1.19so better solution is revert this commit for1.19and release in1.20./cc @prettier/core @g-harel @duailibe