Replies: 2 comments 14 replies
-
|
Go! |
Beta Was this translation helpful? Give feedback.
-
|
Reminder, this may only able to detect simple array? group([hardline, ...])The following cases are all not safe. group(foo ? [...], [hardline, ...])group(join(hardline, ...)); // the second argument can be single |
Beta Was this translation helpful? Give feedback.
-
|
Do you have other cases we can check? |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for your reminder. I have considered:
However, it can't detect #15795 and might not be helpful enough... I might submit PR only if I find even simple rule can detect existing mistakes or come up with better logic. |
Beta Was this translation helpful? Give feedback.
-
|
Oh I've missed #15795 contains not only |
Beta Was this translation helpful? Give feedback.
-
|
I'm wondering why following one can change format... diff --git a/src/language-js/print/jsx.js b/src/language-js/print/jsx.js
index 424756498..e78915c65 100644
--- a/src/language-js/print/jsx.js
+++ b/src/language-js/print/jsx.js
@@ -258,12 +258,12 @@ function printJsxElementInternal(path, options, print) {
return content;
}
- const multiLineElem = group([
+ const multiLineElem = [
openingLines,
indent([hardline, content]),
hardline,
closingLines,
- ]);
+ ];
if (forcedBreak) {
return multiLineElem;↓test result x = (
<div>
<div className="first" tabIndex="1">
First
- </div>
- -
- <div className="second" tabIndex="2">
+ </div>-<div className="second" tabIndex="2">
Second
</div>
</div>
);
x = (
<div>
<div className="first" tabIndex="1">
First
- </div>
- -
- <div className="second" tabIndex="2">
+ </div>-<div className="second" tabIndex="2">
Second
</div>
</div>
);
x = (
<div>
<div className="first" tabIndex="1">
First
- </div>
- -
- <div className="second" tabIndex="2">
+ </div>-<div className="second" tabIndex="2">
Second
</div>
</div>
); <Hello>
test <World /> test
- </Hello>
- 123
+ </Hello>123 |
Beta Was this translation helpful? Give feedback.
-
|
EDIT: simplified. describe("fill", () => {
test("group", () => {
const doc = fill([
group(["{", breakParent]),
softline,
"-",
softline,
group(["}", breakParent]),
]);
expect(docToString(doc, { printWidth: 100 })).toMatchInlineSnapshot(`
"{
-
}"
`);
});
test("array", () => {
const doc = fill([
["{", breakParent],
softline,
"-",
softline,
["}", breakParent],
]);
expect(docToString(doc, { printWidth: 100 })).toMatchInlineSnapshot(
`"{-}"`,
);
});
});older exampledescribe("fill", () => {
test("group", () => {
const doc = fill([
group(["[", indent([hardline, "aaaaa"]), hardline, group("]")]),
softline,
"-",
softline,
group(["[", indent([hardline, "bbbbb"]), hardline, group("]")]),
]);
expect(docToString(doc, { printWidth: 100 })).toMatchInlineSnapshot(`
"[
aaaaa
]
-
[
bbbbb
]"
`);
});
test("array", () => {
const doc = fill([
["[", indent([hardline, "aaaaa"]), hardline, group("]")],
softline,
"-",
softline,
["[", indent([hardline, "bbbbb"]), hardline, group("]")],
]);
expect(docToString(doc, { printWidth: 100 })).toMatchInlineSnapshot(`
"[
aaaaa
]-[
bbbbb
]"
`);
});
}); |
Beta Was this translation helpful? Give feedback.
-
|
Maybe @thorn0 can help? |
Beta Was this translation helpful? Give feedback.
-
|
In block for const doc = fill([
group(["{", breakParent]),
softline,
"-",
softline,
group(["}", breakParent]),
]);goes On the other hand, const doc = fill([
["{", breakParent],
softline,
"-",
softline,
["}", breakParent],
]);yields . So |
Beta Was this translation helpful? Give feedback.
-
|
Is it? diff --git a/src/document/printer.js b/src/document/printer.js
index a12c3a1ec..0fd704f75 100644
--- a/src/document/printer.js
+++ b/src/document/printer.js
@@ -279,6 +279,9 @@ function fits(
if (mode === MODE_BREAK || doc.hard) {
return true;
}
+ if (mustBeFlat && doc.hard) {
+ return false;
+ }
if (!doc.soft) {
out.push(" ");
width--;
@@ -294,6 +297,11 @@ function fits(
return false;
}
break;
+
+ case DOC_TYPE_BREAK_PARENT:
+ if (mustBeFlat) {
+ return false;
+ }
}
}
return false;This change make just one test case failed. |
Beta Was this translation helpful? Give feedback.
-
|
I'll submit a PR for this potential "bug" first. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Isn't it helpful if #15795 and similar problems can be detected by defining internal ESLint rule?
I might try to implement it if members agree.
Beta Was this translation helpful? Give feedback.
All reactions