Compare array index to -1 instead of >= 0 to determine element presence

josephfrazier · josephfrazier · commit c4e08d6eedb7 · 2017-06-01T18:18:40.000-04:00
See #1637 (comment)
diff --git a/src/doc-printer.js b/src/doc-printer.js
@@ -418,7 +418,7 @@ function printDocToString(doc, options) {
   }
 
   const cursorPlaceholderIndex = out.indexOf(cursor.placeholder);
-  if (cursorPlaceholderIndex >= 0) {
+  if (cursorPlaceholderIndex !== -1) {
     const beforeCursor = out.slice(0, cursorPlaceholderIndex).join("");
     options.cursorOffsetResult = beforeCursor.length;
     const afterCursor = out.slice(cursorPlaceholderIndex + 1).join("");

Original file line number	Diff line number	Diff line change
`@@ -418,7 +418,7 @@ function printDocToString(doc, options) {`
`418`	`418`	`}`
`419`	`419`
`420`	`420`	`const cursorPlaceholderIndex = out.indexOf(cursor.placeholder);`
`421`		`- if (cursorPlaceholderIndex >= 0) {`
	`421`	`+ if (cursorPlaceholderIndex !== -1) {`
`422`	`422`	`const beforeCursor = out.slice(0, cursorPlaceholderIndex).join("");`
`423`	`423`	`options.cursorOffsetResult = beforeCursor.length;`
`424`	`424`	`const afterCursor = out.slice(cursorPlaceholderIndex + 1).join("");`