Skip to content

chore: use context properties where context methods are deprecated#594

Merged
BPScott merged 2 commits intoprettier:masterfrom
filiptammergard:context
Oct 29, 2023
Merged

chore: use context properties where context methods are deprecated#594
BPScott merged 2 commits intoprettier:masterfrom
filiptammergard:context

Conversation

@filiptammergard
Copy link
Copy Markdown
Contributor

@filiptammergard filiptammergard commented Oct 26, 2023

But keep supporting the methods for now.

I think this might be considered a chore as it won't affect users of the plugin until ESLint v10 is released.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 26, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c12b522

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@filiptammergard filiptammergard mentioned this pull request Oct 26, 2023
Closed
@JounQin JounQin requested a review from BPScott October 26, 2023 07:47
@BPScott
Copy link
Copy Markdown
Member

BPScott commented Oct 27, 2023

Generally yes and thanks! I'll test this with old and new eslint versions and merge if it all looks good over the weekend

@BPScott
chore: adjust comments
c12b522 
adjust comments
BPScott
BPScott approved these changes Oct 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed up a tweak to the comments, to avoid having long lines - I prefer comments living above code rather than at the end of a code line

@BPScott BPScott merged commit e65b459 into prettier:master Oct 29, 2023
@filiptammergard
Copy link
Copy Markdown
Contributor Author

filiptammergard commented Oct 30, 2023

Great @BPScott ⭐

This was referenced Jun 19, 2024
Open
Open
This was referenced Aug 9, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BPScott BPScott BPScott approved these changes

@JounQin JounQin JounQin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@filiptammergard @BPScott @JounQin