fix: compatibility with prettier@3 without plugins#564
Merged
JounQin merged 2 commits intoprettier:masterfrom Jul 6, 2023
auvred:fix/compat-with-v3-without-plugins
Merged
fix: compatibility with prettier@3 without plugins#564JounQin merged 2 commits intoprettier:masterfrom auvred:fix/compat-with-v3-without-plugins
JounQin merged 2 commits intoprettier:masterfrom
auvred:fix/compat-with-v3-without-plugins
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #563
In
[email protected]the behavior of plugins list default value was changedfrom this:
https://github.com/prettier/prettier/blob/e154250e19caa6d1b23bb1e7803ee5f8d0f95445/src/common/load-plugins.js#L25-L27
to this:
https://github.com/prettier/prettier/blob/266344398c1c90f7dc7b206ba8077cecc294470f/src/main/plugins/load-plugins.js#L3
So
plugins: nullcauses runtime error, the default value should beundefinedas declared there