Add support for eslint-plugin-babel#72
Merged
lydell merged 2 commits intoprettier:masterfrom Jan 19, 2019
silvenon:eslint-plugin-babel
Merged
Add support for eslint-plugin-babel#72lydell merged 2 commits intoprettier:masterfrom silvenon:eslint-plugin-babel
lydell merged 2 commits intoprettier:masterfrom
silvenon:eslint-plugin-babel
Conversation
Contributor
Author
|
Will fix tests tomorrow. |
Contributor
Author
|
Ok, done. I made an exception in the tests when checking for Btw, the test suite is awesome 👌 |
lydell
reviewed
Jan 18, 2019
Member
lydell
left a comment
lydell
left a comment
There was a problem hiding this comment.
Looking good!
I left a few comments. If some of them are too nitpicky – let me know and I'll fix them myself.
Contributor
Author
|
Ok, let me know if I missed something. Feel free to be nitpicky, I like neatness as well 😉 |
Member
|
Thanks! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not aware of any popular ESLint configs that use it so I just left it out of the configuration example for the sake of simplicity, but I think it's visible enough that people will notice that it exists.
Fixes #67.