chore(vue): Use dedicated vue/no-layout-rules config#69
Merged
lydell merged 2 commits intoprettier:masterfrom Jan 3, 2019
Merged
chore(vue): Use dedicated vue/no-layout-rules config#69lydell merged 2 commits intoprettier:masterfrom
lydell merged 2 commits intoprettier:masterfrom
Conversation
j-f1
approved these changes
Jan 2, 2019
Member
|
Thanks! |
Member
|
Release in v3.4.0. |
lydell
added a commit
that referenced
this pull request
Jan 16, 2019
Fixes #70. While the PR was well intended, it unfortunately was breaking change since it requires eslint-plugin-vue@5 while lots of people still use version 4. Also, sometimes there are layout rules that don't conflict with Prettier but rather complement it. So it might make sense to keep a manual, Prettier-specific list after all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
eslint-plugin-vue, as well as updatesvueconfig, by using brand newvue/no-layout-rulesconfig, that is automatically generated based on thetypeproperty in rules' metadata. This way we won't get out-of-sync :)