Skip to content

Disable @typescript-eslint/comma-spacing#135

Merged
lydell merged 2 commits intoprettier:masterfrom
ybiquitous:disable-typescript-eslint-comma-spacing
Jan 28, 2020
Merged

Disable @typescript-eslint/comma-spacing#135
lydell merged 2 commits intoprettier:masterfrom
ybiquitous:disable-typescript-eslint-comma-spacing

Conversation

@ybiquitous
Copy link
Copy Markdown
Contributor

@ybiquitous ybiquitous commented Jan 28, 2020

Fixes #134

@ybiquitous
Copy link
Copy Markdown
Contributor Author

ybiquitous commented Jan 28, 2020

The CI failure is due to the following error:

$ npm run test:lint-rules --silent
TypeError: sourceCode.isSpaceBetween is not a function
Occurred while linting /tmp/eslint-config-prettier/index.js:1
    at validateCommaSpacing (/tmp/eslint-config-prettier/node_modules/@typescript-eslint/eslint-plugin/dist/rules/comma-spacing.js:88:44)
    at Program:exit.tokensAndComments.forEach (/tmp/eslint-config-prettier/node_modules/@typescript-eslint/eslint-plugin/dist/rules/comma-spacing.js:132:21)
    at Array.forEach (<anonymous>)
    at Program:exit (/tmp/eslint-config-prettier/node_modules/@typescript-eslint/eslint-plugin/dist/rules/comma-spacing.js:126:35)
    at listeners.(anonymous function).forEach.listener (/tmp/eslint-config-prettier/node_modules/eslint/lib/linter/safe-emitter.js:45:58)
    at Array.forEach (<anonymous>)
    at Object.emit (/tmp/eslint-config-prettier/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/tmp/eslint-config-prettier/node_modules/eslint/lib/linter/node-event-generator.js:254:26)
    at NodeEventGenerator.applySelectors (/tmp/eslint-config-prettier/node_modules/eslint/lib/linter/node-event-generator.js:283:22)
    at NodeEventGenerator.leaveNode (/tmp/eslint-config-prettier/node_modules/eslint/lib/linter/node-event-generator.js:306:14)

@ybiquitous
Copy link
Copy Markdown
Contributor Author

ybiquitous commented Jan 28, 2020

isSpaceBetween() has been added in ESLint 6.7.2:

eslint/eslint@bc435a9

So, we should bump up our ESLint version:

eslint-config-prettier/package.json

Line 47 in 5cf39be

"eslint": "6.6.0",

@ybiquitous ybiquitous mentioned this pull request Jan 28, 2020
Merged
@ybiquitous
Copy link
Copy Markdown
Contributor Author

ybiquitous commented Jan 28, 2020

I've opened PR #136. This PR will work after we will merge PR #136.

lydell pushed a commit that referenced this pull request Jan 28, 2020
@ybiquitous @lydell
Bump eslint from 6.6.0 to 6.8.0 (#136)
d89bb10 
Follow-up #135
@lydell lydell marked this pull request as ready for review January 28, 2020 07:07
@ybiquitous
Copy link
Copy Markdown
Contributor Author

ybiquitous commented Jan 28, 2020 •
edited
Loading

@lydell Thanks for your merging #136! CI passed expectedly! 🎉

@lydell lydell merged commit 04c79bf into prettier:master Jan 28, 2020
@ybiquitous ybiquitous deleted the disable-typescript-eslint-comma-spacing branch January 28, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Turn off @typescript-eslint/comma-spacing

2 participants

@ybiquitous @lydell