Handle deprecated rules (closes #112)#121
Merged
lydell merged 6 commits intoprettier:masterfrom Oct 26, 2019
Merged
Conversation
Closed
lydell
requested changes
Oct 19, 2019
Member
lydell
left a comment
lydell
left a comment
There was a problem hiding this comment.
Nice!
Now need to add:
- A test.
- Documentation. I think we could add a new sub-heading under Installation. At the end of the Installation section to be specific. Maybe "Excluding deprecated rules". That section would need to explain that eslint-config-prettier turns off a couple of deprecated rules and that that is nothing to worry about usually. Then we could mention the
eslint-find-rulesuse case.
Co-Authored-By: Simon Lydell <[email protected]>
Contributor
Author
|
@lydell I think I'm done. |
Member
|
Thanks! I’ll get back to you this weekend. |
lydell
approved these changes
Oct 26, 2019
Contributor
Author
|
@lydell Cool, I like the the updates you've made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can now pass an environment variable to tell
eslint-config-prettiernot to add deprecated rules.Details