arrow-body-style and prefer-arrow-callback cause trouble with eslint-plugin-prettier: https://github.com/prettier/eslint-config-prettier/tree/9444ee0b20f9af3ff364f62d6a9ab967ad673a9d#arrow-body-style-and-prefer-arrow-callback
Prettier de-emphasizes eslint-plugin-prettier these days, so I think we should remove those rules from "extends": "prettier" and move them to a separate file, just like we do for other plugins (react, flowtype, vue, etc). Those two rules are useful and I think it’s a shame that they’re turned off by default – in vain for many.
The difference this time is that all other plugin-specific files include only rules from the plugin in question. For eslint-plugin-prettier we’d only add arrow-body-style and prefer-arrow-callback, which are ESLint core rules, but I think it makes sense.
The question is what to call the config. So far the naming scheme for eslint-plugin-foo is "extends": "prettier/foo". I this case that would be:
{
"extends": [
"prettier",
"prettier/prettier"
]
}
… which makes sense if you think about it, but is pretty confusing. Maybe the full plugin name is better in this case?
{
"extends": [
"prettier",
"prettier/eslint-plugin-prettier"
]
}
Or, is it better if we only remove arrow-body-style and prefer-arrow-callback, and let eslint-plugin-prettier add those rules to their config instead? @BPScott any thoughts?
arrow-body-style and prefer-arrow-callback cause trouble with eslint-plugin-prettier: https://github.com/prettier/eslint-config-prettier/tree/9444ee0b20f9af3ff364f62d6a9ab967ad673a9d#arrow-body-style-and-prefer-arrow-callback
Prettier de-emphasizes eslint-plugin-prettier these days, so I think we should remove those rules from
"extends": "prettier"and move them to a separate file, just like we do for other plugins (react, flowtype, vue, etc). Those two rules are useful and I think it’s a shame that they’re turned off by default – in vain for many.The difference this time is that all other plugin-specific files include only rules from the plugin in question. For eslint-plugin-prettier we’d only add arrow-body-style and prefer-arrow-callback, which are ESLint core rules, but I think it makes sense.
The question is what to call the config. So far the naming scheme for eslint-plugin-foo is
"extends": "prettier/foo". I this case that would be:{ "extends": [ "prettier", "prettier/prettier" ] }… which makes sense if you think about it, but is pretty confusing. Maybe the full plugin name is better in this case?
{ "extends": [ "prettier", "prettier/eslint-plugin-prettier" ] }Or, is it better if we only remove arrow-body-style and prefer-arrow-callback, and let eslint-plugin-prettier add those rules to their config instead? @BPScott any thoughts?