[FIX]: Validation failures should fail the build#85
Merged
tonymeehan merged 4 commits intoprequel-dev:mainfrom Jun 17, 2025
Merged
[FIX]: Validation failures should fail the build#85tonymeehan merged 4 commits intoprequel-dev:mainfrom
tonymeehan merged 4 commits intoprequel-dev:mainfrom
Conversation
Contributor
amanycodes
commented
Jun 15, 2025
amanycodes
commented
- Fixed a bug where the main function was not failing on validation errors, which caused the build check to pass even when errors were present.
- I also updated the build workflow to be less redundant and more robust by removing the unnecessary matrix go versioning and added .
- To support the improved workflow, I added a standard test command to the Makefile for convenience.
Signed-off-by: amanycodes <[email protected]>
Signed-off-by: amanycodes <[email protected]>
Contributor
Author
|
cc @tonymeehan |
Contributor
|
@amanycodes this looks good. Mind updating conflicts and then we should be good to merge! Nice work! |
Signed-off-by: amanycodes <[email protected]>
Contributor
Author
|
@tonymeehan Thanks! I have fixed the merged conflicts and also fixed a rule which again went uncaught in checks. Please merge this one first so that we don't fall into the errors again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.