Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended server functionality by implementing FAILOVER command #875

Merged
merged 24 commits into from
Dec 29, 2022
Merged

Extended server functionality by implementing FAILOVER command #875

merged 24 commits into from
Dec 29, 2022

Conversation

vladvildanov
Copy link
Contributor

Vladyslav Vildanov added 23 commits December 14, 2022 12:07
Added arrayable arguments classes
f93f16e
Updated count trait to accept additional modifier argument
1627280
Added new With traits, moved into separate directory
7246a04
Added traits for geo command arguments resolving
2476096
Remove BaseWith trait, not working with traits nesting
a0d792b
Added AscDesc trait
7187cb4
Rename AscDesc traint into Sorting
df294a5
Fixed trait keyword
ecb8a6f
Removed unnecessary traits
8c58a7a
Updated count trait to handle default argument value
a702881
Fixed With traits offset check condition
e7bfa52
Added GeoFrom, GeoBy traits
addb186
Fixes for Count and Sorting traits
2dd7038
Fixed variable names in with traits
786bdce
[WIP] Added GEOSEARCH command support, without test coverage
8fb9090
Changed functionality to support only lower case units (Redis 6.0 sup…
6076f6c 
…port)
Merge branch 'main' of github.com:vladvildanov/predis into vv-848-geo…
baaf24a 
…search-command
Changed namespace for WITHSCORES trait
b97ab9d
Merge branch 'main' of github.com:vladvildanov/predis into vv-848-geo…
49241ca 
…search-command
Added more test coverage, added response parsing
155ddbf
Added test coverage for tratis
d29c99f
Merge branch 'main' of github.com:vladvildanov/predis into vv-848-geo…
729f4c6 
…search-command
Added support for FAILOVER command
ab34811
@vladvildanov vladvildanov marked this pull request as draft December 28, 2022 14:33
@vladvildanov vladvildanov linked an issue Dec 28, 2022 that may be closed by this pull request
Add support for missing redis command FAILOVER #847
Closed
@vladvildanov vladvildanov marked this pull request as ready for review December 29, 2022 07:18
@tillkruss tillkruss merged commit 721c829 into predis:main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillkruss tillkruss Awaiting requested review from tillkruss tillkruss is a code owner

@chayim chayim Awaiting requested review from chayim

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for missing redis command FAILOVER
2 participants
@vladvildanov @tillkruss