Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Sorted Set support by implementing BZPOPMAX command #864

Merged
merged 11 commits into from
Dec 13, 2022
Merged

Extend Sorted Set support by implementing BZPOPMAX command #864

merged 11 commits into from
Dec 13, 2022

Conversation

vladvildanov
Copy link
Contributor

@vladvildanov vladvildanov linked an issue Dec 13, 2022 that may be closed by this pull request
Add support for missing redis command BZPOPMAX #841
Closed
sazzad16
sazzad16 suggested changes Dec 13, 2022
View reviewed changes
src/Command/Redis/BZPOPMAX.php Outdated
* A member with the highest score is popped from first sorted set that is non-empty,
* with the given keys being checked in the order that they are given.
*/
class BZPOPMAX extends BZPOPMIN
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right. Either we can have a BZPOPBase which would be extended by both BZPOPMAX and BZPOPMIN or these two would be independent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sazzad16 Fixed

@tillkruss tillkruss requested a review from sazzad16 December 13, 2022 16:39
@tillkruss tillkruss merged commit f26fd89 into predis:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sazzad16 sazzad16 sazzad16 approved these changes

@tillkruss tillkruss Awaiting requested review from tillkruss tillkruss is a code owner

@chayim chayim Awaiting requested review from chayim

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for missing redis command BZPOPMAX
3 participants
@vladvildanov @sazzad16 @tillkruss