Extended Sorted Set support by adding ZUNION command #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 8, 2022 12:10
tillkruss
reviewed
Dec 12, 2022
| @@ -127,6 +127,7 @@ | |||
| * @method $this zrevrange($key, $start, $stop, array $options = null) | |||
| * @method $this zrevrangebyscore($key, $max, $min, array $options = null) | |||
| * @method $this zrevrank($key, $member) | |||
| * @method $this zunion(array $keys, int[] $weights = [], string $aggregate = 'sum', bool $withScores = false) | |||
There was a problem hiding this comment.
Should keys and weights be a single array?
There was a problem hiding this comment.
Not sure If I get you. If you mean argument types, then I think both of them should be arrays.
For keys it's definitely should be, since we need to resolve numkeys argument and the easiest way is to calculate array count and we already have a trait for it. For weights it's optional, but in my opinion it's always easy to deal with single element the same way we're dealing with collection, in this case we don't need to maintain different implementations for different argument types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#839
@dvora-h @sazzad16